Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on edit fee #5491

Merged
merged 7 commits into from
Nov 24, 2023
Merged

Fix crash on edit fee #5491

merged 7 commits into from
Nov 24, 2023

Conversation

eniolam1000752
Copy link
Contributor

@eniolam1000752 eniolam1000752 commented Nov 24, 2023 •
edited by ManuGowda
Loading

What was the problem?

This PR resolves #5487, #5489 and #5493

How was it solved?

  • Add MAX_ACCURACY to validation list on FeeViewer

How was it tested?

  • Navigate to send token form
  • Initiate an edit fee action
  • input Floating point value whose size is more than 8 (e.g 1.0000000033)
  • it should be observed that a max accuracy error should be shown.

@eniolam1000752 eniolam1000752 self-assigned this Nov 24, 2023
@ManuGowda ManuGowda requested review from ManuGowda and removed request for ikem-legend November 24, 2023 13:58
ManuGowda
ManuGowda approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@ManuGowda ManuGowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The hover issue is still not 100% resolved, so I moved the issue out of this PR.

What has done now in regards to hover is better than before.

@eniolam1000752 eniolam1000752 merged commit 3d93105 into release/3.0.0 Nov 24, 2023
3 checks passed
@eniolam1000752 eniolam1000752 deleted the 5487-fix-crash-on-edit-fee branch November 24, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskarleonard oskarleonard oskarleonard approved these changes

@ManuGowda ManuGowda ManuGowda approved these changes

Assignees

@eniolam1000752 eniolam1000752

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eniolam1000752 @ManuGowda @oskarleonard