-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate useTransaction fee hook on all transactions #4761
Integrate useTransaction fee hook on all transactions #4761
Conversation
Minor refactoring to send form and transaction fee computation
2ef8f4a
to
45d9ccc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job 🎉
src/modules/auth/hooks/queries/useGetInitializationFees.test.js
Outdated
Show resolved
Hide resolved
src/modules/pos/validator/components/UnlockBalanceForm/index.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replied to few comments. I think test will still fail due to
export const FEE_TYPES = {
BYTES_FEE: 'bytesFee',
PRIORITY_FEE: 'priorityFee',
USER_ACCOUNT_INITIALIZATION: 'userAccountInitialization',
ESCROW_ACCOUNT_INITIALIZATION: 'escrowAccountInitialization',
VALIDATOR_REGISTRATION: 'validatorRegistration',
};
Merging this PR as Ali reviewed and approved it offline, since he his on holiday until monday we are merging with one approval. |
What was the problem?
This PR resolves #4717, #4719, #4781
How was it solved?
usePriority
fee hookuseTransactionFee
hook to only consumeuseByteFee
hook andusePriority
hookuseTransactionFee
hook into TxComposerHow was it tested?