Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use transaction fee hook to calculate and display fees in transaction forms #4719

Closed
Tracked by #4341
reyraa opened this issue Jan 13, 2023 · 0 comments
Closed
Tracked by #4341

Use transaction fee hook to calculate and display fees in transaction forms #4719

reyraa opened this issue Jan 13, 2023 · 0 comments
Assignees
@eniolam1000752
Labels
domain: transaction type: improvement
Milestone
Sprint 92

Comments

@reyraa
Copy link
Contributor

reyraa commented Jan 13, 2023 •
edited
Loading

Description

Assuming #4718 completes the requirements of the fee calculation, now it's time to adapt our React components to the new data structure.
We should update data wiring to match the changes applied by #4716 to #4718. The form component should display the total feee, alongside each fee component. It should also display human readable titles (with i18n) for each component.

Acceptance criteria

  • Compose titles for all fee components
  • Only display none-zero fee components
  • Emphasis on the display of the total fee (Larger font, prominent color)
  • Adapt unit tests
  • Assert the returned value of useTransactionFee.
@ManuGowda ManuGowda changed the title Use above fee to display fees in tx forms Use transaction fee hook to calculate and display fees in transaction forms Jan 16, 2023
@ManuGowda ManuGowda added this to the Sprint 91 milestone Jan 16, 2023
@ManuGowda ManuGowda moved this from Backlog to Todo in Lisk Desktop Version 3.0.0 Jan 17, 2023
@ManuGowda ManuGowda moved this from Todo to In Progress in Lisk Desktop Version 3.0.0 Jan 18, 2023
@eniolam1000752 eniolam1000752 mentioned this issue Jan 26, 2023
Merged
7 tasks
@ManuGowda ManuGowda assigned eniolam1000752 and unassigned reyraa Jan 26, 2023
@sridharmeganathan sridharmeganathan mentioned this issue Jan 31, 2023
Closed
80 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Lisk Desktop Version 3.0.0 Feb 1, 2023
@ManuGowda ManuGowda mentioned this issue Feb 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eniolam1000752 eniolam1000752

Labels
domain: transaction type: improvement
Projects
No open projects
Lisk Desktop Version 3.0.0
Status: Done
Milestone
Sprint 92
Development

No branches or pull requests
4 participants
@reyraa @ManuGowda @eniolam1000752 @sridharmeganathan