-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commission rate and reward #4706
Add commission rate and reward #4706
Conversation
src/modules/pos/validator/components/ValidatorProfile/PerformanceView.js
Outdated
Show resolved
Hide resolved
src/modules/pos/validator/components/ValidatorProfile/DetailsView.js
Outdated
Show resolved
Hide resolved
@@ -231,6 +232,8 @@ import dropdownFieldIcon from '@setup/react/assets/images/icons/drop-down-field- | |||
import transferArrow from '@setup/react/assets/images/icons/transfer-arrow.svg'; | |||
import receivedTransactionIcon from '@setup/react/assets/images/icons/received_transaction_icon.svg'; | |||
import sentTransactionIcon from '@setup/react/assets/images/icons/sent_transaction_icon.svg'; | |||
import commissionsIcon from '@setup/react/assets/images/icons/commissions.svg'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import commissionIcon from '@setup/react/assets/images/icons/commission.svg'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following feature has broken
- Show
My validator profile
once registered
if a validator is registered, we should not show again the registration button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small changes required for variable naming and test data
What was the problem?
This PR resolves #4641 and #4643
How was it solved?
See reward break down
link on rewards cardHow was it tested?