Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commission rate and reward #4706

Merged
merged 13 commits into from
Jan 13, 2023

Conversation

eniolam1000752
Copy link
Contributor

@eniolam1000752 eniolam1000752 commented Jan 10, 2023

What was the problem?

This PR resolves #4641 and #4643

How was it solved?

  • Introduce commissions display in validator profile page
  • Introduce See reward break down link on rewards card
  • Introduce commission display on edit/add stake modal
  • introduce validator commission on staking queue
  • Add unit test

How was it tested?

  • Visually
  • jest

@eniolam1000752 eniolam1000752 self-assigned this Jan 10, 2023
@eniolam1000752 eniolam1000752 marked this pull request as ready for review January 12, 2023 00:07
src/modules/pos/validator/components/EditStake/index.js Outdated Show resolved Hide resolved
src/modules/pos/validator/components/EditStake/index.js Outdated Show resolved Hide resolved
src/modules/pos/validator/components/StakeForm/StakeRow.js Outdated Show resolved Hide resolved
src/modules/pos/validator/consts/validators.js Outdated Show resolved Hide resolved
src/modules/pos/validator/store/actions/staking.js Outdated Show resolved Hide resolved
src/modules/pos/validator/store/actions/staking.js Outdated Show resolved Hide resolved
src/modules/pos/validator/store/actions/staking.js Outdated Show resolved Hide resolved
src/modules/pos/validator/store/actions/staking.test.js Outdated Show resolved Hide resolved
@@ -231,6 +232,8 @@ import dropdownFieldIcon from '@setup/react/assets/images/icons/drop-down-field-
import transferArrow from '@setup/react/assets/images/icons/transfer-arrow.svg';
import receivedTransactionIcon from '@setup/react/assets/images/icons/received_transaction_icon.svg';
import sentTransactionIcon from '@setup/react/assets/images/icons/sent_transaction_icon.svg';
import commissionsIcon from '@setup/react/assets/images/icons/commissions.svg';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import commissionIcon from '@setup/react/assets/images/icons/commission.svg'

Copy link
Contributor

@ManuGowda ManuGowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following feature has broken

  • Show My validator profile once registered

if a validator is registered, we should not show again the registration button

Copy link
Contributor

@ManuGowda ManuGowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid commission

Screenshot 2023-01-12 at 5 34 20 PM

Copy link
Contributor

@ManuGowda ManuGowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes required for variable naming and test data

@soroushm soroushm merged commit 66aa868 into feature/dpos-update Jan 13, 2023
@soroushm soroushm deleted the 4641-add-commission-rate-and-reward branch January 13, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants