Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working on e2e test fix - Closes #3456 #3841

Merged
merged 25 commits into from
Nov 3, 2021

Conversation

ikem-legend
Copy link
Member

What was the problem?

This PR resolves #3456

How was it solved?

By updating the Cypress configuration

How was it tested?

Manually running end to end tests

@ikem-legend ikem-legend self-assigned this Oct 8, 2021
@reyraa reyraa force-pushed the 3456-fix-broken-e2e-test-lisk-sdk branch from a7b17eb to 740aa17 Compare October 29, 2021 09:25
@reyraa reyraa force-pushed the 3456-fix-broken-e2e-test-lisk-sdk branch from b1afb84 to 12cc4cb Compare October 29, 2021 09:32
Copy link
Contributor

@ManuGowda ManuGowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @reyraa 🎉
For the commented e2e tests, either we can address them here #3734
or you can fix it in this PR as well.

But rest LGTM once login tests are green

Then I see successful message
When I am on Wallet page
Then The latest transaction is Delegate registration
# Background:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe create an issue to fix them, if not fixed in this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a ticket for this already. #3734

@reyraa reyraa marked this pull request as ready for review November 3, 2021 09:52
@reyraa reyraa merged commit 3161ee7 into development Nov 3, 2021
@reyraa reyraa deleted the 3456-fix-broken-e2e-test-lisk-sdk branch November 3, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken e2e tests due to adapting to Lisk SDK v5
4 participants