Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve e2e test suite #3734

Closed
Tracked by #3794
sridharmeganathan opened this issue Aug 17, 2021 · 3 comments · Fixed by #4024
Closed
Tracked by #3794

Improve e2e test suite #3734

sridharmeganathan opened this issue Aug 17, 2021 · 3 comments · Fixed by #4024
Assignees
Milestone

Comments

@sridharmeganathan
Copy link
Contributor

sridharmeganathan commented Aug 17, 2021

Description

The below points should be addressed to fix the unstable and failing e2e test

  • We have duplicated step definitions and many step definitions are defined for a specific feature while they can be in common feature to prevent duplication
  • We have step definitions that perform several assertions, increasing the chance of code duplication.
  • Accounts and transactions are used in common, thus changing one feature can affect the features that run next.
  • All tests run against a single machine. Parallelising can decrease the run times by about 50%
  • Wallet filters and Send feature are unstable

Acceptance Criteria

  • We should move as many step definitions as possible to common steps.
  • Each step should only assert one goal. We should refactor the complex step definitions down to several steps with a single assertion.
  • We should create accounts specific to each feature so the result of feature don't affect the next features.
  • We should determine if Cypress allows running features with parameter. If not, we should break cypress config into two and run e2e test only using Jekins parameter and against master
  • We should investigate running e2e test on multiple machines in parallel.
  • We check if defining feature specific accounts help, if not, we refactor these features and resolve fragile tests.
@sridharmeganathan
Copy link
Contributor Author

@reyraa to update the title and scope of this issue.

@ManuGowda ManuGowda changed the title Fix e2e tests which are failing and unstable Improve e2e test suite Dec 13, 2021
@ManuGowda ManuGowda added this to the Spike 3 milestone Dec 17, 2021
@ManuGowda ManuGowda modified the milestones: Spike 3, Sprint 65 Jan 1, 2022
@eniolam1000752
Copy link
Contributor

eniolam1000752 commented Jan 3, 2022

Pending work

  • configure Jenkins to run on devnet for this PR
  • refactoring send.feature file
  • refactoring vote.feature file

@eniolam1000752
Copy link
Contributor

eniolam1000752 commented Jan 3, 2022

Requirements from me

  • find a way to parameterize serivceUrl in config.json for cypress
  • provide snapshot DB
  • provide a parameter that enables DevOps to know when lisk-service is up and running

reyraa added a commit that referenced this issue Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants