Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update delegate profile UI - Closes #3755 #3808

Merged
merged 16 commits into from
Sep 30, 2021

Conversation

ikem-legend
Copy link
Member

What was the problem?

This PR resolves #3755

How was it solved?

It was solved by implementing the updated delegate profile UI

How was it tested?

Visually

@ikem-legend ikem-legend marked this pull request as ready for review September 24, 2021 09:43
@ManuGowda ManuGowda requested review from sridharmeganathan and removed request for ManuGowda September 24, 2021 09:50
i18n/locales/en/common.json Outdated Show resolved Hide resolved
src/constants/routes.js Outdated Show resolved Hide resolved
src/components/screens/wallet/delegatePerformance/index.js Outdated Show resolved Hide resolved
@ikem-legend ikem-legend requested a review from isalga September 24, 2021 15:29
isalga
isalga previously approved these changes Sep 27, 2021
Copy link
Contributor

@reyraa reyraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good.
Please take a look at dark and light mode. Also compare and correct the font sizes.
Thank you

Screenshot 2021-09-27 at 16 18 11

@ann-vashchenko
Copy link

ann-vashchenko commented Sep 27, 2021

Hi @ikem-legend I have some feedback:

  1. Font weight of the title is incorrect. (see screenshot 1)
  2. Margins from the left and right sides should be equal (see screenshot 1)
  3. Please change the text color for the dark mode (see screenshot 2)
  4. Please change the illustration for the dark mode, you can find them here (they're ready for export)
  5. The modal window should be smaller (see screenshot 3)

Screenshot 1
Screenshot 2021-09-27 at 16 44 44

Screenshot 2
Screenshot 2021-09-27 at 16 50 38

Screenshot 3
Screenshot 2021-09-27 at 17 31 19

@ManuGowda ManuGowda requested review from reyraa and isalga and removed request for sridharmeganathan September 28, 2021 06:47
@ann-vashchenko
Copy link

Hi @ikem-legend thank you for the updates, could you check the description text on the modal window on the dark mode (screenshot 1) and the alignment (screenshot 2)

screenshot 1
Screenshot 2021-09-29 at 12 51 18

screenshot 2
Screenshot 2021-09-29 at 12 51 42

@reyraa
Copy link
Contributor

reyraa commented Sep 29, 2021

Good job. Most of the problems are resolved. I only discovered one more issue. in 1245px the screen seems a bit broken. we have to support down to 768px.

Screenshot 2021-09-29 at 13 02 14

@ikem-legend
Copy link
Member Author

Good job. Most of the problems are resolved. I only discovered one more issue. in 1245px the screen seems a bit broken. we have to support down to 768px.

Screenshot 2021-09-29 at 13 02 14

I'm guessing you're referring to the "Last forged blocks" section under details. I'll fix that

@ikem-legend
Copy link
Member Author

Hi @ikem-legend thank you for the updates, could you check the description text on the modal window on the dark mode (screenshot 1) and the alignment (screenshot 2)

screenshot 1 Screenshot 2021-09-29 at 12 51 18

screenshot 2 Screenshot 2021-09-29 at 12 51 42

Fixed

@reyraa reyraa merged commit b8b7305 into development Sep 30, 2021
@reyraa reyraa deleted the 3755-update-delegate-profile-ui branch September 30, 2021 09:54
@reyraa reyraa removed the request for review from ann-vashchenko September 30, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add delegate failsafe banning mechanism support to delegate profile
4 participants