Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transactions showing -0BTC for small values - Resolves #2882 #2883

Merged
merged 9 commits into from
May 22, 2020
Merged

Fix transactions showing -0BTC for small values - Resolves #2882 #2883

merged 9 commits into from
May 22, 2020

Conversation

reyraa
Copy link
Contributor

@reyraa reyraa commented May 13, 2020 •
edited
Loading

What was the problem?

This PR resolves #2882

How was it solved?

  • Accepts showInt and showRounded parameters.
  • If showInt passed, it shows only the integer value.
  • If showRounded passed:
    • if the value is over 100, it shows only two digits if the floating part is not zero.
    • If the value is under 100, it displays at least one non-zero digit after the floating-point.

How was it tested?

Visually and unit test

@reyraa reyraa self-assigned this May 13, 2020
@reyraa reyraa requested a review from sridharmeganathan May 22, 2020 09:36
@reyraa reyraa merged commit f1078b4 into development May 22, 2020
@reyraa reyraa deleted the 2882-increase-floating-digits branch May 22, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sridharmeganathan sridharmeganathan sridharmeganathan approved these changes

Assignees

@reyraa reyraa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transactions show -0BTC for small values
2 participants
@reyraa @sridharmeganathan