Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialization buttons are not well aligned - Closes #1553 #1552 #1551 #1550 #1554

Merged
merged 17 commits into from
Dec 10, 2018

Conversation

osvaldovega
Copy link
Contributor

What issue have I solved?

-- #1553
-- #1552
-- #1551
-- #1550

How have I implemented/fixed it?

Fix css files of the components that have the issue.
Fix the problem of reload the app when user is in request page, there was a problem passing one of the props to the child components.

How has this been tested?

By interface and by unit test.

Review checklist

Migrate integration tests of wallet - Closes #1538
michaeltomasik
michaeltomasik previously approved these changes Dec 10, 2018
Copy link
Contributor

@michaeltomasik michaeltomasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job 👍

Copy link
Contributor

@Efefefef Efefefef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛 If not signed in, URL shortcut /wallet/request should redirect to the login page like in the other cases

@osvaldovega
Copy link
Contributor Author

after rebase I think this property got erase, it is fixed now

@Efefefef
Copy link
Contributor

Thank you Osvaldo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants