Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate integration tests of wallet - Closes #1538 #1541

Merged
merged 6 commits into from
Dec 7, 2018

Conversation

Efefefef
Copy link
Contributor

@Efefefef Efefefef commented Dec 5, 2018

What issue have I solved?

-- #1538

How have I implemented/fixed it?

Move some tests to transfer.spec, some to activity.spec
wallet.js should be removed afterwards

How has this been tested?

Review checklist

@Efefefef Efefefef force-pushed the 1538-migrate-integration-wallet] branch from 07fcc5a to be798c1 Compare December 5, 2018 14:23
@slaweet slaweet changed the base branch from development to 1.8.0 December 5, 2018 14:25
@Efefefef Efefefef force-pushed the 1538-migrate-integration-wallet] branch 2 times, most recently from 1db1fbf to 66be5b9 Compare December 5, 2018 15:08
@Efefefef Efefefef force-pushed the 1538-migrate-integration-wallet] branch from 66be5b9 to e03d215 Compare December 5, 2018 15:18
@Efefefef Efefefef requested a review from slaweet December 5, 2018 15:22
@Efefefef Efefefef force-pushed the 1538-migrate-integration-wallet] branch 2 times, most recently from e5d788e to 793f800 Compare December 5, 2018 16:50
@slaweet slaweet changed the title Migrate integration wallet - Closes #1538 Migrate integration tests of wallet - Closes #1538 Dec 5, 2018
@Efefefef Efefefef force-pushed the 1538-migrate-integration-wallet] branch from 793f800 to a62e5d8 Compare December 5, 2018 17:39
@Efefefef Efefefef force-pushed the 1538-migrate-integration-wallet] branch from a62e5d8 to b3409c0 Compare December 5, 2018 18:02
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Andrei.

@Efefefef Efefefef merged commit be37bf5 into 1.8.0 Dec 7, 2018
@Efefefef Efefefef deleted the 1538-migrate-integration-wallet] branch December 7, 2018 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants