Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display 'No standby delegates found' instead of 'Nothing found' #3948

Closed
Tracked by #3963
isalga opened this issue Nov 23, 2021 · 0 comments · Fixed by #3990
Closed
Tracked by #3963

Display 'No standby delegates found' instead of 'Nothing found' #3948

isalga opened this issue Nov 23, 2021 · 0 comments · Fixed by #3990
Assignees
@isalga
Labels
type: improvement
Milestone
Sprint 63

Comments

@isalga
Copy link
Contributor

isalga commented Nov 23, 2021

Description

Given the case that there are no delegates with voteWeight over 1000 LSK to be eligible as standby, API returns 404 to the call for standby delegates (https://testnet-service.lisk.com/api/v2/accounts?isDelegate=true&limit=20&status=standby) resulting on table to display Nothing found.

Motivation

As a user perspective this result seems like an error when it is an expected behaviour.

Additional Information

Screenshot from 2021-11-22 10-47-58.png
@isalga isalga self-assigned this Nov 23, 2021
@sridharmeganathan sridharmeganathan mentioned this issue Nov 23, 2021
Closed
8 tasks
@sridharmeganathan sridharmeganathan modified the milestone: Sprint 62 Nov 23, 2021
This was referenced Nov 24, 2021
Closed
Closed
@isalga isalga mentioned this issue Dec 1, 2021
Merged
reyraa added a commit that referenced this issue Dec 3, 2021
@reyraa
Merge pull request #3990 from LiskHQ/3948-display-no-standby-delegate…
fc252a3 
…s-found

Display no standby delegates found message and inelegible delegates - Closes #3948
@sridharmeganathan sridharmeganathan added this to the Sprint 63 milestone Dec 7, 2021
@sridharmeganathan sridharmeganathan mentioned this issue Dec 7, 2021
Closed
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isalga isalga

Labels
type: improvement
Projects
None yet
Milestone
Sprint 63
2 participants
@isalga @sridharmeganathan