Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Indicate in API response when there are no delegates that fulfil minimum vote weight to be eligible as standby #889

Closed
isalga opened this issue Nov 24, 2021 · 1 comment
Closed

Indicate in API response when there are no delegates that fulfil minimum vote weight to be eligible as standby #889

isalga opened this issue Nov 24, 2021 · 1 comment
Labels
type: duplicate

Comments

@isalga
Copy link

isalga commented Nov 24, 2021

Description

Supply a specific error or response (empty array) that indicates when there are no delegates that fulfil minimum vote weight to be standby.

Motivation

Currently API returns 404 when there are no delegates with voteWeight over 1000 LSK to be eligible as standby on this call (https://testnet-service.lisk.com/api/v2/accounts?isDelegate=true&limit=20&status=standby). As Desktop team plans to display a label that indicates no standby delegates were found instead of a general 'nothing found'. For that desktop needs a specific way of indicating that case instead of a 404

Additional Information

@LiskHQ/lisk-desktop#3948
@isalga isalga self-assigned this Nov 24, 2021
@sameersubudhi sameersubudhi changed the title Indicate in API response when there are no delegates that fulfil minimum vote weight to be elegible as standby Indicate in API response when there are no delegates that fulfil minimum vote weight to be eligible as standby Nov 29, 2021
@reyraa
Copy link

reyraa commented Nov 30, 2021

Duplicate of #888

@reyraa reyraa marked this as a duplicate of #888 Nov 30, 2021
@reyraa reyraa closed this as completed Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@reyraa @isalga @sridharmeganathan