Skip to content
This repository was archived by the owner on Jun 11, 2024. It is now read-only.

Update example app #8836

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Conversation

Incede
Copy link
Contributor

@Incede Incede commented Aug 9, 2023

What was the problem?

This PR resolves #8830 #8833

How was it solved?

  • Fix default application initialization in pos-sidechain-example-one
  • Update genesis assets and blocks as specified

How was it tested?

Mint & transfer nft from mainchain to sidechain one

@Incede Incede requested review from shuse2 and ishantiw August 9, 2023 20:49
@Incede Incede self-assigned this Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #8836 (4be282d) into feature/6917-implement-nft-module (2a0cc2d) will decrease coverage by 0.01%.
Report is 2 commits behind head on feature/6917-implement-nft-module.
The diff coverage is 100.00%.

❗ Current head 4be282d differs from pull request most recent head d34b864. Consider uploading reports for the commit d34b864 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                          Coverage Diff                          @@
##           feature/6917-implement-nft-module    #8836      +/-   ##
=====================================================================
- Coverage                              83.97%   83.97%   -0.01%     
=====================================================================
  Files                                    623      623              
  Lines                                  23279    23276       -3     
  Branches                                3400     3400              
=====================================================================
- Hits                                   19548    19545       -3     
  Misses                                  3731     3731              
Files Changed Coverage Δ
framework/src/modules/nft/method.ts 99.18% <ø> (-0.01%) ⬇️
...amework/src/modules/nft/cc_commands/cc_transfer.ts 97.46% <100.00%> (+0.03%) ⬆️

... and 2 files with indirect coverage changes

Base automatically changed from 8832-exists to feature/6917-implement-nft-module August 11, 2023 07:19
@shuse2 shuse2 enabled auto-merge (squash) August 11, 2023 07:19
@shuse2 shuse2 merged commit 78ee063 into feature/6917-implement-nft-module Aug 11, 2023
@shuse2 shuse2 deleted the 8833-update-example-app branch August 11, 2023 07:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants