Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Check that the secret key is non-zero modulo the order of the elliptic curve #8829

Merged
merged 16 commits into from
Aug 17, 2023
Merged

Check that the secret key is non-zero modulo the order of the elliptic curve #8829

merged 16 commits into from
Aug 17, 2023

Commits on Aug 9, 2023

  1. Check the secret key 

    Ensure that the secret key generated using the `SecretKey.fromBytes` function is non-zero modulo the order of the elliptic curve.
    @mosmartin
    mosmartin committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    170e999 View commit details
    Browse the repository at this point in the history

  2. Add unit tests

    @mosmartin
    mosmartin committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    65bf2a0 View commit details
    Browse the repository at this point in the history

  3. Refactor the isSecretKeyNonZeroModEC function logic

    @mosmartin
    mosmartin committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    8a1aaa1 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Add unit test 

    Case for a secret key that is non-zero but zero modulo the group order must hold
    @mosmartin
    mosmartin committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    ace7eb2 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Refactor the blsSign function 

    - Update the blsSign function
- Add and update unit tests
    @mosmartin
    mosmartin committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    b3e9f22 View commit details
    Browse the repository at this point in the history

  2. Update unit test

    @mosmartin
    mosmartin committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    bac6e36 View commit details
    Browse the repository at this point in the history

  3. Remove already tested case

    @mosmartin
    mosmartin committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    a8e6ffb View commit details
    Browse the repository at this point in the history

  4. Remove already tested case

    @mosmartin
    mosmartin committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    879f9bd View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Update unit test 

    Remove unnecessary checks

Co-authored-by: AndreasKendziorra <40799768+AndreasKendziorra@users.noreply.github.com>
    @mosmartin @AndreasKendziorra
    mosmartin and AndreasKendziorra authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    b9db0ec View commit details
    Browse the repository at this point in the history

  2. Update test description 

    Co-authored-by: AndreasKendziorra <40799768+AndreasKendziorra@users.noreply.github.com>
    @mosmartin @AndreasKendziorra
    mosmartin and AndreasKendziorra authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    f00485f View commit details
    Browse the repository at this point in the history

  3. Update test desc 

    Co-authored-by: AndreasKendziorra <40799768+AndreasKendziorra@users.noreply.github.com>
    @mosmartin @AndreasKendziorra
    mosmartin and AndreasKendziorra authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    e229ec2 View commit details
    Browse the repository at this point in the history

  4. Update test desc 

    Co-authored-by: AndreasKendziorra <40799768+AndreasKendziorra@users.noreply.github.com>
    @mosmartin @AndreasKendziorra
    mosmartin and AndreasKendziorra authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    cf6866c View commit details
    Browse the repository at this point in the history

  5. Refactor the secret key checks and tests

    @mosmartin
    mosmartin committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    5498c1d View commit details
    Browse the repository at this point in the history

  6. Merge branch '8783-bls-sk-checks' of github.com:LiskHQ/lisk-sdk into … 

    …8783-bls-sk-checks
    @mosmartin
    mosmartin committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    f442e8e View commit details
    Browse the repository at this point in the history

  7. Add a unit test 

    Test that `blsPopProve` function throws an an error when the sk is zero
    @mosmartin
    mosmartin committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    98b14dc View commit details
    Browse the repository at this point in the history

  8. Merge branch 'release/6.0.0' into 8783-bls-sk-checks

    @shuse2
    shuse2 authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    c9a37b4 View commit details
    Browse the repository at this point in the history