This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Check that the secret key is non-zero modulo the order of the elliptic curve #8829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the secret key generated using the `SecretKey.fromBytes` function is non-zero modulo the order of the elliptic curve.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/6.0.0 #8829 +/- ##
==============================================
Coverage 83.41% 83.42%
==============================================
Files 601 601
Lines 22467 22479 +12
Branches 3318 3321 +3
==============================================
+ Hits 18740 18752 +12
Misses 3727 3727
|
shuse2
reviewed
Aug 9, 2023
shuse2
approved these changes
Aug 10, 2023
shuse2
changed the title
Case for a secret key that is non-zero but zero modulo the group order must hold
- Update the blsSign function - Add and update unit tests
shuse2
reviewed
Aug 16, 2023
AndreasKendziorra
suggested changes
Aug 17, 2023
Remove unnecessary checks Co-authored-by: AndreasKendziorra <40799768+AndreasKendziorra@users.noreply.github.com>
Co-authored-by: AndreasKendziorra <40799768+AndreasKendziorra@users.noreply.github.com>
Co-authored-by: AndreasKendziorra <40799768+AndreasKendziorra@users.noreply.github.com>
Co-authored-by: AndreasKendziorra <40799768+AndreasKendziorra@users.noreply.github.com>
…8783-bls-sk-checks
AndreasKendziorra
suggested changes
Aug 17, 2023
Test that `blsPopProve` function throws an an error when the sk is zero
AndreasKendziorra
approved these changes
Aug 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8783
How was it solved?
Added the
isSecretKeyNonZeroModECfunction to check that the secret key generated using theSecretKey.fromBytesfunction is non-zero modulo the order of the elliptic curve.How was it tested?
Added unit tests