_id and _lastUpdated search bindvariables are not added #577 #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Bind Variables to Inclusion and Sorted Query Segment Aggregators - Verify with tests - Whole System Search with SORT and without SORT - Resource Specific Search with SORT and without SORT Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
prb112
changed the title
- Update the Copyright headers to match YYYY,<SPACE>YYYY - Update InclusionQuerySegmentAggregator to support multiple bindvariables Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
prb112
changed the title
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
prb112
requested review from
lmsurpre and
albertwang-ibm
and removed request for
lmsurpre
...e-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/util/InclusionQuerySegmentAggregator.java
Show resolved
Hide resolved
...e-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/util/InclusionQuerySegmentAggregator.java
Show resolved
Hide resolved
...e/src/test/java/com/ibm/fhir/persistence/search/test/AbstractSearchIdAndLastUpdatedTest.java
Show resolved
Hide resolved
- per code review Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
lmsurpre
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul Bastide pbastide@us.ibm.com