Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_id and _lastUpdated search bindvariables are not added to QuerySegmentAggregators #577

Closed
prb112 opened this issue Jan 10, 2020 · 0 comments
Closed

_id and _lastUpdated search bindvariables are not added to QuerySegmentAggregators #577

prb112 opened this issue Jan 10, 2020 · 0 comments
Assignees
@prb112
Labels
bug Something isn't working search
Milestone
Sprint 7

Comments

@prb112
Copy link
Contributor

prb112 commented Jan 10, 2020

_id and _lastUpdated search bindvariables are not added to QuerySegmentAggregators

_id and _lastUpdated were converted to use derived tables. The default call on a single resource works:
https://localhost:9443/fhir-server/api/v4/Location?_lastUpdated=gt2018-01-01&_format=application/fhir+json

The system-wide search does not work, and must be fixed.
https://localhost:9443/fhir-server/api/v4?_lastUpdated=gt2018-01-01&_format=application/fhir+json&

The SortQuerySegmentAggregator for resource and global also does not work properly (not assigning bindvariables)
https://localhost:9443/fhir-server/api/v4/Location?_lastUpdated=gt2018-01-01&_format=application/fhir+json&_sort=_lastUpdated

Also check Include Query Segment Aggregator.
@prb112 prb112 added bug Something isn't working search labels Jan 10, 2020
@prb112 prb112 added this to the Sprint 7 milestone Jan 10, 2020
@prb112 prb112 self-assigned this Jan 10, 2020
prb112 added a commit that referenced this issue Jan 11, 2020
@prb112
_id and _lastUpdated search bindvariables are not added #577
d40474b 
- Add Bind Variables to Inclusion and Sorted Query Segment Aggregators
- Verify with tests
	- Whole System Search with SORT and without SORT
	- Resource Specific Search with SORT and without SORT

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
prb112 added a commit that referenced this issue Jan 14, 2020
@prb112
Update for #588 and #577
0d493a4 
- UriBuilder returns invalid self/url #588
	- Updated the lowerBound to be the only one output in queryparamval
	- Added test to check the reflexsivity of a URL in SearchAllTest

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
prb112 added a commit that referenced this issue Jan 14, 2020
@prb112
Update for #588 and #577
3a12887 
- Update the Copyright headers to match YYYY,<SPACE>YYYY
- Update InclusionQuerySegmentAggregator to support multiple
bindvariables

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
prb112 added a commit that referenced this issue Jan 14, 2020
@prb112
Merge pull request #578 from IBM/issue-577
db72598 
_id and _lastUpdated search bindvariables are not added #577
@prb112 prb112 closed this as completed Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prb112 prb112

Labels
bug Something isn't working search
Projects
None yet
Milestone
Sprint 7
Development

No branches or pull requests
1 participant
@prb112