Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #160 conditional read support #556

Merged
merged 10 commits into from
Jan 7, 2020
Merged

issue #160 conditional read support #556

merged 10 commits into from
Jan 7, 2020

Conversation

albertwang-ibm
Copy link
Contributor

@albertwang-ibm albertwang-ibm commented Jan 6, 2020

  1. Added full support for conditional read:
    (1) Support If-Modified-Since
    Support RFC_1123, RFC_850, ANSIC and touchstone date time formats.
    (2) Support If-None-Match
    Support ETag value with or without " (and W/)
    e.g: 1, "1", W/1, W/"1" (the first format is used by TouchStone)
  2. Added statement of conditional read full support to server capability.
  3. Added server integrations tests for conditional read.
  4. Fixed the date time format of Last-Modified response header.
  5. Updated last-modified response header test codes accordingly.

albertwang-ibm and others added 4 commits January 2, 2020 09:02
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
@albertwang-ibm albertwang-ibm changed the title WIP: issue #160 conditional read support issue #160 conditional read support Jan 6, 2020
@albertwang-ibm albertwang-ibm added this to the Sprint 7 milestone Jan 6, 2020
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
Copy link
Contributor

@prb112 prb112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prb112 prb112 added the enhancement New feature or request label Jan 7, 2020
@prb112 prb112 merged commit d288d15 into master Jan 7, 2020
@prb112 prb112 deleted the Albert-Master-New2 branch January 7, 2020 19:12
@@ -1,5 +1,5 @@
/*
* (C) Copyright IBM Corp. 2016,2019
* (C) Copyright IBM Corp. 2020
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was not right. should have been 2016,2020

@@ -1,5 +1,5 @@
/*
* (C) Copyright IBM Corp. 2016,2019
* (C) Copyright IBM Corp. 2020
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not right. should be 2016,2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants