Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support conditional read operation #160

Closed
albertwang-ibm opened this issue Sep 27, 2019 · 2 comments
Closed

Support conditional read operation #160

albertwang-ibm opened this issue Sep 27, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@albertwang-ibm
Copy link
Contributor

albertwang-ibm commented Sep 27, 2019

We should give client the option of performing a conditional read. This should save bandwidth and reduce latency for frequently accessed resources.

From https://www.hl7.org/FHIR/DSTU2/http.html#cread:

Clients may use the If-Modified-Since, or If-None-Match HTTP header on a read request. If so, they MUST accept either a 304 Not Modified as a valid status code on the response (which means that the content is unchanged since that date) or full content (either the content has not changed, or the server does not support conditional request).

Servers can return 304 Not Modified where content is unchanged since the If-Modified-Since date-time or the If-None-Match ETag specified or they can return the full content as normal. This optimisation is relevant in reducing bandwidth for caching purposes and servers are encouraged but not required to support this. If servers don't support conditional read, they just return the full content.

https://touchstone.aegis.net/touchstone/scriptexecution?exec=201909271137469410753433&qn=/FHIR4-0-0-Advanced/Patient/01-read/fhir-api-r4-patient-read-04-conditional-found-notmodified#WAITING_OPER

@albertwang-ibm albertwang-ibm added the enhancement New feature or request label Sep 27, 2019
@albertwang-ibm albertwang-ibm added this to the Sprint 2 milestone Sep 27, 2019
@albertwang-ibm
Copy link
Contributor Author

This could be low priority for us before we don't support this in our capabilitystatement, and touchstone knows that we don't support this by checking our capabilitystatement.

@senthilbak senthilbak removed this from the Sprint 2 milestone Oct 14, 2019
@albertwang-ibm albertwang-ibm changed the title Support If-Modified-Since for resource read operation Support conditional read operation Jan 6, 2020
albertwang-ibm added a commit that referenced this issue Jan 6, 2020
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
albertwang-ibm added a commit that referenced this issue Jan 6, 2020
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
albertwang-ibm added a commit that referenced this issue Jan 6, 2020
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
@albertwang-ibm albertwang-ibm added this to the Sprint 7 milestone Jan 6, 2020
albertwang-ibm added a commit that referenced this issue Jan 6, 2020
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
albertwang-ibm added a commit that referenced this issue Jan 7, 2020
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
albertwang-ibm added a commit that referenced this issue Jan 7, 2020
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
albertwang-ibm added a commit that referenced this issue Jan 7, 2020
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
albertwang-ibm added a commit that referenced this issue Jan 7, 2020
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
prb112 added a commit that referenced this issue Jan 7, 2020
@lmsurpre lmsurpre self-assigned this Jan 7, 2020
@albertwang-ibm
Copy link
Contributor Author

verified in touchstone test, so close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants