issue #4023 - use FHIRPersistenceTransaction instead of ITransactionProvider #4024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmsurpre
commented
Oct 13, 2022
Comment on lines
+340
to
+343
| private static final Set<FHIRPathType> SYSTEM_TYPES = | ||
| Set.of(SYSTEM_BOOLEAN, SYSTEM_STRING, SYSTEM_INTEGER, SYSTEM_DECIMAL, SYSTEM_DATE, SYSTEM_DATE_TIME, SYSTEM_QUANTITY, SYSTEM_TIME); | ||
| private static final Set<FHIRPathType> METAMODEL_TYPES = | ||
| Set.of(SYSTEM_TYPE_INFO, SYSTEM_CLASS_INFO, SYSTEM_TUPLE_TYPE_INFO, SYSTEM_LIST_TYPE_INFO, SYSTEM_SIMPLE_TYPE_INFO); |
There was a problem hiding this comment.
just a random cleanup/update I was sitting on... now that we're on java 11 we can use Set.of() :-)
lmsurpre
commented
Oct 13, 2022
Comment on lines
+336
to
+337
| // path (with array indices) -> Extension instance (which never have a url version suffix) | ||
| Map<String, Extension> pathToExtension = gatherInstanceExtensions(resourceNode); |
There was a problem hiding this comment.
another minor formatting thing I had locally... the foreach on the next line references pathToExtension and so it made more sense for this to be the line which proceeds that
lmsurpre
force-pushed
the
issue-4023
branch
2 times, most recently
from
bd20079 to
87c1b06
Compare
…rovider Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that the callback for inserting search parameter values is invoked.
I'm expecting this to fail until #4021 is addressed... which actually means its working.
Signed-off-by: Lee Surprenant lmsurpre@merative.com