You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Prasanna found #4021 by manually executing our fhir-server-test suite.
This was a bad regression and pointed to a fundamental gap in our testing.
For 5.0, the parameter processing was reworked so that the parameter inserts happen just before the transaction commits
This relies on the use of our FHIRPersistenceTransaction abstraction under fhir-persistence.
However, when I dug into this test it turns out it was using SimpleTransactionProvider from fhir-database-utils instead, and so we were never calling the IFHIRTransactionAdapterCallback which triggers the inserts.
Environment
Which version of LinuxForHealth FHIR Server? 5.0
After the fix, the CI pipeline was failing as expected until the fix for #4021 landed. I think that is sufficient to show that the persistence tests are now covering the parameters flush (at least on derby).
Describe the bug
Prasanna found #4021 by manually executing our fhir-server-test suite.
This was a bad regression and pointed to a fundamental gap in our testing.
For 5.0, the parameter processing was reworked so that the parameter inserts happen just before the transaction commits
This relies on the use of our FHIRPersistenceTransaction abstraction under fhir-persistence.
However, when I dug into this test it turns out it was using SimpleTransactionProvider from fhir-database-utils instead, and so we were never calling the IFHIRTransactionAdapterCallback which triggers the inserts.
Environment
Which version of LinuxForHealth FHIR Server? 5.0
To Reproduce
Steps to reproduce the behavior:
Note that the test succeeds. This is because the problematic search parameter was never actually written.
Expected behavior
The test should execute the IFHIRTransactionAdapterCallback and thus it should fail when there is a problem with this code.
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: