Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2427 - Add missing modifiers to FHIRParameters in FHIR Client #2437

Merged
merged 3 commits into from
Jun 2, 2021

Conversation

tbieste
Copy link
Contributor

@tbieste tbieste commented May 26, 2021

Issue #2427 - Add missing modifiers to FHIRParameters in FHIR Client

Signed-off-by: Troy Biesterfeld tbieste@us.ibm.com

@tbieste tbieste self-assigned this May 26, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
@tbieste tbieste force-pushed the tbieste-issue-2427 branch from a85f464 to a3e0c72 Compare May 26, 2021 21:03
@tbieste tbieste requested a review from lmsurpre May 26, 2021 21:05
@tbieste tbieste marked this pull request as ready for review May 26, 2021 21:05
@JohnTimm JohnTimm requested a review from csandersdev May 27, 2021 13:26
Copy link
Contributor

@prb112 prb112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mind updating the SearchConstants per the conversation?

Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Copy link
Contributor

@csandersdev csandersdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I split the reference chaining request into a separate issue. For the rest LGTM.

Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
@tbieste tbieste merged commit ceb3714 into main Jun 2, 2021
@tbieste tbieste deleted the tbieste-issue-2427 branch June 2, 2021 19:51
tbieste added a commit that referenced this pull request Jun 9, 2021
Issue #2427 - Add missing modifiers to FHIRParameters in FHIR Client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants