-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing identifier modifier in FHIRParameters.Modifier enum #2427
Comments
Something else to consider here is the value/utility of the TYPE member of the FHIRParameters.Modifier enum. If I'm writing client code and I want to filter on a specific type |
One more thought on FHIRParameters is that reference chaining is not well supported in the FHIRParameters class right now. If I wanted to do |
Looks like we are also missing the "of-type" modifier for token. |
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
This covers most of what I mentioned above, but do we want to do anything in this PR around my third comment above regarding reference chaining? I'd be happy to split that into a separate issue if the team wants to handle that separately. |
Yeah, I prefer to keep things close to the original bug; to avoid feature creep in work items. If this satisfies the original bug, then opening a separate issue for the item in your third comment sounds good to me. |
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Issue #2427 - Add missing modifiers to FHIRParameters in FHIR Client
Confirmed that the new prefixes were added to the enums and that the new |
Issue #2427 - Add missing modifiers to FHIRParameters in FHIR Client
Describe the bug
The conformance guide says that we support the Reference :identifier modifier, but it is not declared in the fhir-client module FHIRParameters.Modifier enum.
Environment
4.8.1
To Reproduce
Steps to reproduce the behavior:
Expected behavior
All supported modifiers are declared in the enum.
The text was updated successfully, but these errors were encountered: