Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor payload persistence to its own visitor in Bundle processing #3145

Closed
punktilious opened this issue Dec 24, 2021 · 1 comment
Closed

Refactor payload persistence to its own visitor in Bundle processing #3145

punktilious opened this issue Dec 24, 2021 · 1 comment
Assignees
@punktilious
Labels
breaking-change-java Identifies a change in a method signature that an implementer may use. technical debt

Comments

@punktilious
Copy link
Collaborator

Describe the bug
Currently the payload persistence step is invoked within the FHIRRestInteractionVisitorReferenceMapping visitor, which is the last time the resource is modified and therefore the first opportunity to store the payload.

This, is a little obscure. It could be much clearer (with probably very little performance impact) to loop through the Bundle entries again to perform the offload in a dedicated visitor. This would only need to be done if offload were enabled - which requires a FHIRPersistence method to support this check.

Environment
Which version of IBM FHIR Server? main
@lmsurpre lmsurpre mentioned this issue Jan 4, 2022
Merged
@lmsurpre lmsurpre added the breaking-change-java Identifies a change in a method signature that an implementer may use. label Jan 26, 2022
@punktilious punktilious self-assigned this Feb 8, 2022
punktilious added a commit that referenced this issue Feb 8, 2022
@punktilious
issue #3145 move offload processing to its own interaction visitor fo…
fae9452 
…r bundle processing

Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
@punktilious punktilious mentioned this issue Feb 9, 2022
Merged
punktilious added a commit that referenced this issue Feb 14, 2022
@punktilious
issue #3145 do not store payload for deleted versions
cbe142d 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
punktilious added a commit that referenced this issue Feb 15, 2022
@punktilious
issue #3145 need to provide resource for afterDelete event
f2647b8 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
punktilious added a commit that referenced this issue Feb 15, 2022
@punktilious
issue #3145 ChunkWriter needs to use new persistence read API to hand…
57da30f 
…le deleted resources

Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
punktilious added a commit that referenced this issue Feb 16, 2022
@punktilious
issue #3145 copyright and comment cleanup
b9f4bb5 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
lmsurpre added a commit that referenced this issue Feb 16, 2022
@lmsurpre
Merge pull request #3314 from IBM/issue-3145
d27e61c 
issue #3145 move offload processing to its own interaction visitor
@lmsurpre
Copy link
Member

QA for this will be included with the QA for 3293: #3293 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@punktilious punktilious

Labels
breaking-change-java Identifies a change in a method signature that an implementer may use. technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lmsurpre @punktilious