Issue #2900 Cassandra implementation of payload offload including rollback support #3142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
…etch Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
lmsurpre
added
the
new-module
|
we should add fhir-persistence-blob to the list of modules in our README |
lmsurpre
reviewed
Dec 23, 2021
lmsurpre
reviewed
Dec 23, 2021
fhir-persistence-blob/src/main/java/com/ibm/fhir/persistence/blob/BlobContainerManager.java
Show resolved
Hide resolved
lmsurpre
reviewed
Dec 23, 2021
fhir-persistence-blob/src/main/java/com/ibm/fhir/persistence/blob/BlobReadPayload.java
Show resolved
Hide resolved
lmsurpre
reviewed
Dec 23, 2021
fhir-persistence-blob/src/main/java/com/ibm/fhir/persistence/blob/BlobReadPayload.java
Show resolved
Hide resolved
lmsurpre
reviewed
Dec 23, 2021
...erver/src/main/java/com/ibm/fhir/server/rest/FHIRRestInteractionVisitorReferenceMapping.java
Show resolved
Hide resolved
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
lmsurpre
reviewed
Jan 4, 2022
lmsurpre
reviewed
Jan 5, 2022
...ersistence/src/main/java/com/ibm/fhir/persistence/context/FHIRPersistenceContextFactory.java
Show resolved
Hide resolved
lmsurpre
reviewed
Jan 5, 2022
...ersistence/src/main/java/com/ibm/fhir/persistence/context/FHIRPersistenceContextFactory.java
Show resolved
Hide resolved
lmsurpre
reviewed
Jan 5, 2022
fhir-persistence/src/main/java/com/ibm/fhir/persistence/payload/FHIRPayloadPersistence.java
Show resolved
Hide resolved
lmsurpre
reviewed
Jan 5, 2022
fhir-persistence/src/main/java/com/ibm/fhir/persistence/payload/FHIRPayloadPersistence.java
Show resolved
Hide resolved
lmsurpre
reviewed
Jan 5, 2022
fhir-persistence/src/main/java/com/ibm/fhir/persistence/payload/PayloadPersistenceHelper.java
Show resolved
Hide resolved
lmsurpre
reviewed
Jan 5, 2022
fhir-persistence/src/main/java/com/ibm/fhir/persistence/payload/PayloadPersistenceResponse.java
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Jan 5, 2022
fhir-persistence/src/main/java/com/ibm/fhir/persistence/payload/PayloadPersistenceResponse.java
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Jan 5, 2022
fhir-persistence/src/main/java/com/ibm/fhir/persistence/payload/PayloadReaderImpl.java
Show resolved
Hide resolved
lmsurpre
reviewed
Jan 5, 2022
fhir-persistence/src/main/java/com/ibm/fhir/persistence/util/InputOutputByteStream.java
Show resolved
Hide resolved
lmsurpre
reviewed
Jan 5, 2022
lmsurpre
reviewed
Jan 5, 2022
|
General question: are these changes abstracted from the FHIRPersistenceInterceptor or will interceptor implementations need to be aware of changes to the FHIRPersistenceContext and/or event object? And same question for audit... |
lmsurpre
reviewed
Jan 5, 2022
...erver/src/main/java/com/ibm/fhir/server/rest/FHIRRestInteractionVisitorReferenceMapping.java
Show resolved
Hide resolved
lmsurpre
reviewed
Jan 5, 2022
fhir-server/src/main/java/com/ibm/fhir/server/util/FHIRRestHelper.java
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Jan 5, 2022
fhir-persistence/src/main/java/com/ibm/fhir/persistence/FHIRPersistence.java
Show resolved
Hide resolved
lmsurpre
reviewed
Jan 5, 2022
fhir-smart/src/test/java/com/ibm/fhir/smart/test/MockPersistenceImpl.java
Outdated
Show resolved
Hide resolved
Robin confirmed that the context and event objects should be the same as before. One difference is that the persistence context will now have the offloadPayloadResponse, but that is strictly additive and interceptors should continue to work as expected. |
…ation scanning Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
lmsurpre
reviewed
Jan 10, 2022
...-cassandra/src/main/java/com/ibm/fhir/persistence/cassandra/reconcile/ResourceExistsDAO.java
Show resolved
Hide resolved
lmsurpre
reviewed
Jan 10, 2022
...-cassandra/src/main/java/com/ibm/fhir/persistence/cassandra/reconcile/ResourceExistsDAO.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.