Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#837 Modified PdfPTable add cell method to return cell (*Breaking Changes*) #844

Merged
merged 1 commit into from
Feb 13, 2024
Merged

#837 Modified PdfPTable add cell method to return cell (*Breaking Changes*) #844

merged 1 commit into from
Feb 13, 2024

Conversation

jaybob007
Copy link
Contributor

@jaybob007 jaybob007 commented Oct 30, 2022 •
edited
Loading

Updated PdfPTable addCell methods to return the cell that was added.

Related Issue: #837

@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonatype-lift
Copy link

sonatype-lift bot commented Oct 30, 2022

⚠️ 80 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

@lmove
Copy link

lmove commented Nov 18, 2022

Hi! Our tool BreakBot found that this pull request introduces 5 breaking changes and they appear to impact 1 of your clients. You can find the full BreakBot report in our fork repository: report for PR#844.

We hope this information is valuable to you, and apologize otherwise. If you're willing to help, we would kindly ask for your help to fill in a 5-minutes survey about the report. Your feedback will help us improve the tool and provide a better experience for users in the future!

@asturio asturio added this to the 1.4.0 milestone Jan 16, 2023
@asturio
Copy link
Member

asturio commented Jan 16, 2023

Will add this to 1.4.0 because of breaking changes.

@andreasrosdal andreasrosdal changed the title #837 Modified PdfPTable add cell method to return cell #837 Modified PdfPTable add cell method to return cell (*Breaking Changes*) Nov 2, 2023
@andreasrosdal andreasrosdal reopened this Feb 13, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@andreasrosdal andreasrosdal merged commit de7a7f8 into LibrePDF:master Feb 13, 2024
6 of 8 checks passed
@laeubi
Copy link

laeubi commented Feb 14, 2024

Thank you 👍

@henricook henricook mentioned this pull request Feb 19, 2024
Closed
@andreasrosdal andreasrosdal mentioned this pull request Feb 20, 2024
Merged
2 tasks
@lgemeinhardt lgemeinhardt mentioned this pull request Feb 22, 2024
Closed
asturio added a commit that referenced this pull request Feb 22, 2024
@asturio
Revert "#837 Modified PdfPTable add cell method to return cell (#844)"
4e9da4e 
This reverts commit de7a7f8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jaybob007 @lmove @asturio @laeubi @andreasrosdal