Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.3.x should not contain breaking changes like https://github.com/LibrePDF/OpenPDF/pull/844 #1070

Closed
lgemeinhardt opened this issue Feb 22, 2024 · 3 comments
Assignees
Labels

Comments

@lgemeinhardt
Copy link

Version 1.3.x should not contain breaking changes like #844, because this minor version update (like 1.3.40 to 1.3.41) does not reflect this.
For Version 1.4.x or better 2.x this is totally fine.

@asturio
Copy link
Member

asturio commented Feb 22, 2024

Pull requests are welcome. Should the commit 9d35857 be reverted?

As only the return value was changed from "void" to PdfPCell, we were not expecting any issues with this. Your code should compile fine. It may be necessary to recompile, but without changes.

@lgemeinhardt
Copy link
Author

Revert this (for sure only in the 1.3 branch) would be fine.
For sure recompiled code does not have any issues, but w/o (like using an "external" jar) runs into a NoSuchMethodError (because the return type is part of the bytecode signature).

@asturio asturio self-assigned this Feb 22, 2024
@asturio
Copy link
Member

asturio commented Feb 22, 2024

Reverted, comming in next release of 1.3

@asturio asturio closed this as completed Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants