Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Mods/admins can mark comments other than their own as distinguished #4216

Closed
4 tasks done
SleeplessOne1917 opened this issue Nov 30, 2023 · 3 comments
Closed
4 tasks done
Labels
bug Something isn't working

Comments

@SleeplessOne1917
Copy link
Member

Requirements

  • Is this a bug report? For questions or discussions use https://lemmy.ml/c/lemmy_support
  • Did you check to see if this issue already exists?
  • Is this only a single bug? Do not put multiple bugs in one issue.
  • Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.

Summary

While working on this UI PR, I noticed that the API allows mods and admins who aren't their own.

Steps to Reproduce

  1. Make API request to distinguish someone else's comment using the JWT for an admin or moderator account.
  2. Receive successful response

Technical Details

N/A

Version

0.19.0-rc.11

Lemmy Instance URL

local

@aeharding
Copy link

@asimons04 to your own point, in Voyager distinguishing a comment of a normal user would make them appear as a moderator, which isn't ideal.

Sticking a comment from a user at the top (without distinguishing) feels like it could be a new feature :)

@aeharding
Copy link

aeharding commented Dec 1, 2023

Treating the distinguished flag as "Speak as moderator" seems redundant since mods can already be badged based on their mod status flag.

I agree in lemmy-ui it is strange how moderators are always tagged as moderators, regardless of distinguished status. In Voyager and Reddit for example, the distinguished flag is so that mods can participate in a conversion without being labelled as a mod, and then mods can distinguish their own comments for specific mod duties.

Ultimately, I no longer care. This is the final straw for me, and I've decided to stop development of Tesseract since everything I do to improve the Lemmy experience is being undone piece by piece by the latest changes to the API.

:( That is unfortunate, I saw Tesseract a few days ago and its a great client! You should be very proud of what you built! 💙

@LemmyNet LemmyNet deleted a comment from asimons04 Dec 1, 2023
@LemmyNet LemmyNet deleted a comment from asimons04 Dec 1, 2023
@LemmyNet LemmyNet deleted a comment from asimons04 Dec 1, 2023
@LemmyNet LemmyNet deleted a comment from asimons04 Dec 1, 2023
@LemmyNet LemmyNet deleted a comment from asimons04 Dec 1, 2023
@dessalines
Copy link
Member

dessalines commented Dec 1, 2023

Distinguish was meant to mean "speak as moderator", not "sticky this comment to the top". What you're talking about is something different, like pin or sticky , and would need to be added separately.

There's no need to loudly announce your exit also. No one is forcing you to develop for lemmy. If you disagree with API changes, let us know in other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants