-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moderation/content action overhaul #2258
Conversation
…to remove-post
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm testing the functionality rn, but you might as well start on i18n, because there's a lot of it. We can always tweak those strings later.
@dessalines Regarding speak as moderator, I got this comment on a PR I opened for the backend. It seems people think it's a feature and not a bug. It may be worth keeping the current functionality and just changing the verbiage in the dropdown. cc @Nutomic |
@Nutomic got that fixed in LemmyNet/lemmy#4222 (IE, only letting you distinguish your own comment). |
I addressed everything that needed to be addressed. The only thing that I can't do much about at the moment are the purge issues you pointed out. I ran into issues with purges, but they didn't break the page like you described. From what I've done:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the missing i18n below:
- After any modal is shown then dismissed (such as remove / restore a comment) it breaks scrolling, and I have to do a page refresh.
Everything else seems to be working well tho.
@dessalines all your points are addressed. Should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Everything tested out great. We can address any smaller bugs later. I'll start a build to put this on voyager.lemmy.ml in a minute.
Description
This started out as a simple bug fix and turned into a full scale refactor and UI overhaul because the existing UI for this stuff was pretty janky. The screenshots should show what I'm going for.
Note: Some existing icons were deleted to use pairs of icons that have the same art style.
Screenshots
Mod action dropdown - comment
Mod action dropdown - post
Ban dialog
Report dialog
The remove dropdown looks the same.
Purge dialog
Transfer community dialog
The appoint as mod and appoint as admin are basically the same.
TODO: