Fix copy title from metadata #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hrm... didn't work. Click it the first time, it doesn't copy. Alter the URL again, then click copy, and it works the 2nd time only. |
|
I see the issue. It works the first time if the url field loses focus, but it doesn't work the first time when you go from the url field directly to the copy button. |
SleeplessOne1917
commented
Jun 7, 2024
Comment on lines
+194
to
+198
| i.setState({ | ||
| urlBlurTimeout: setTimeout(() => { | ||
| i.updateUrl(() => i.props.onUrlBlur?.(event.target.value)); | ||
| }, 500), | ||
| }); |
There was a problem hiding this comment.
A kludge. It fixes the bug at least.
dessalines
approved these changes
Jun 7, 2024
matc-pub
reviewed
Jun 7, 2024
| @@ -354,6 +367,10 @@ export class PostForm extends Component<PostFormProps, PostFormState> { | |||
| }, | |||
| }; | |||
| } | |||
|
|
|||
| if (this.state.form.url) { | |||
| this.fetchPageTitle(); | |||
There was a problem hiding this comment.
This calls setState in the constructor. Probably only a problem for dev builds.
There was a problem hiding this comment.
And should also be client side only.
|
There are still a few issues with both cross-posting, and copy title. We can fix them for the next bugfix release tho. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2516
Alternative to #2517