Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added litely-compact and darkly-compact - issue 552 #1438

Merged
merged 9 commits into from
Jun 23, 2023

Conversation

dankxiaobong
Copy link
Contributor

@dankxiaobong dankxiaobong commented Jun 21, 2023

Added darkly-compact in relation to issue #552
Took a similiar approach as here: #1400 albeit due to significant markup hacky af

Features:

  • Reduced .post-listing height from ~100px+ down to ~80px per post
  • 1920px Desktop Breakpoint
  • Removed user and community icons (.img-icon)

Preview:

darkly-compact
Screenshot from 2023-06-21 11-17-30
Screenshot from 2023-06-21 13-50-12

litely-compact
Screenshot from 2023-06-21 13-47-38
Screenshot from 2023-06-21 13-49-35

If someone shows me how to connect lemmy-ui to lemmy.ml #1153 I'd be able to do comments too. Currently, I'm not able to post comments on my local instance

@dankxiaobong dankxiaobong changed the title added darkly-compact - issue 552 added litely-compact and darkly-compact - issue 552 Jun 21, 2023
@Lloir
Copy link

Lloir commented Jun 21, 2023

Just to add a comment to this, if you have a custom theme folder set, it'll duplicate in the themes drop down AND cause some issues. Once that's disabled it's all goochi.

But I love this 10/10

Copy link
Member

@SleeplessOne1917 SleeplessOne1917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I'll wait until after 0.18 is released to merge this.

@alectrocute
Copy link
Contributor

I think if we’re going to make a compact theme variation, we should make it much more compact. This feels like, slightly more compact. Thoughts?

@dankxiaobong
Copy link
Contributor Author

I think if we’re going to make a compact theme variation, we should make it much more compact. This feels like, slightly more compact. Thoughts?

I absolutely agree that we should go even more compact.

I had these concerns:

  • Changing font and icon sizes alters the overall feel of the base theme. Might as well start a new theme instead of a variation
  • Decreasing icons sizes and their paddings affects mobile/touchdisplays navigation negatively (@media-queries + bs = no thank)
  • Doing rearrangements of elements with current markup and bs utility classes makes it really difficult and feels dirty. And will likely break
    (I read that there's plans to go with tailwind which imo doesn't make it better. @jsit's proposal WIP: test(css): Proof of concept for possible approach to using custom CSS class names #1371 with a lot flatter markup would make theming a lot easier and more flexible. )

This imo is a good compromise to get something out quick in order to satisfy user demand.
(Also I was looking for a good first contribution I'm comfortable with. A lot of the other issues on lemmy are way above my dev skills :P)

Is there anything particularly aggravating that needs fixing?

@dankxiaobong dankxiaobong requested a review from jsit as a code owner June 23, 2023 19:33
@SleeplessOne1917 SleeplessOne1917 merged commit c5e1722 into LemmyNet:main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants