Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(themes): Reorganize themes Sass and add Litely Compact #1400

Closed
wants to merge 2 commits into from

Conversation

jsit
Copy link
Contributor

@jsit jsit commented Jun 19, 2023

Here's an attempt at (a) reorganizing the Sass stylesheets and (b) adding a "Litely Compact" theme (screenshots below). All I'm doing is changing the values of $spacer and $font-size-base to tighten things up, similar to what #1395 is doing.

What I'd actually like to see is each theme in its own Sass subdirectory, with the files being compiled into a flat css directory, but that would require a more thorough rewrite of the themes:build script.

Litely

Screenshot 2023-06-19 at 5 15 20 PM

Litely Compact (new)

Screenshot 2023-06-19 at 5 14 58 PM

@jsit jsit changed the title feat: Reorganize themes Sass and add Litely Compact feat(themes): Reorganize themes Sass and add Litely Compact Jun 19, 2023
@dankxiaobong
Copy link
Contributor

Not sure if this is the right place to ask, but how did you add that theme to the user settings? I tried taking _variables.darkly.scss and darkly.scss renamed it to _variables.darkly-compact.scss and darkly-compact.scss (updated the import) and ran "yarn run themes:build". Do I have to run an additional script?

@jsit
Copy link
Contributor Author

jsit commented Jun 20, 2023

@dankxiaobong It's in build-themes-list.ts, but I think it will also offer any themes in the extra_themes directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants