Fix Menu Close Fidget Logic #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks lincoln! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simply only does the player fidget rands
when the
MenuCloseTypeis notHoldingDirectionas fidgets do not happen when holding a direction. additionally removes the erroneous rand(360) for this case & removes the unimplemented cave types as they are not actually unique. this change is not tested as I do not have a build environment set up but should logically be fine. it's worth noting that currently there is never a case where the value ofModeis notMenuCloseType.Regularas the only place where this is an option (MenuCloseTimelinesubform) does not actually consider the user input for the "Holding direction?" checkbox.