Refactor: LowGasAlert errors on EVM #7782
Merged
+132
β61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β Checklist
npx changeset
was attached.π Description
The previous PR #5780 introduced changes to how errors were managed in the
SendAmountField
component from EVM. It assumed that only Send was using theSendAmountField
, which led to issues when the component was reused in other flows, such as Swap and Sign. This caused multiple errors to be displayed inconsistently, as seen in the attached screenshots.Fixes in this PR:
gasPriceError
and related errors are handled in the Swap and Send flows.NotEnoughGas
andGasPrice
are consistently handled across different flows without duplicating logic of buy click and redirectionLowGasAlertBuyMore
component to simplify the logic and centralize the error handling and Buy actionSendAmountFields
to be closed like modalsThe changes aim to improve consistency in error management across different flows allowing more flexibility in usage, features and tracking
Screenshots of the Sign flow fixed on the triple error. Now consistent with every other flow and tracking correctly the redirection
β Context
π§ Checklist for the PR Reviewers