Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(LLM/send): New gas fees parent account error #5780

Merged
merged 3 commits into from
Jan 12, 2024
Merged

feat(LLM/send): New gas fees parent account error #5780

merged 3 commits into from
Jan 12, 2024

Conversation

mle-gall
Copy link
Contributor

@mle-gall mle-gall commented Dec 19, 2023 •
edited by jira bot
Loading

📝 Description

New insufficient funds errors when selecting a token for which the parent account doesn't have enough balance to pay gas fees + partial visual rework of the gas fees selector (colors & border radii)

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-12-19.at.11.11.52.mp4

❓ Context

✅ Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests.

  • [ ] Impact of the changes:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mle-gall mle-gall requested review from a team as code owners December 19, 2023 10:18
@vercel Vercel
Copy link

vercel bot commented Dec 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jan 11, 2024 5:57pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 11, 2024 5:57pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 11, 2024 5:57pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 11, 2024 5:57pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 11, 2024 5:57pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Dec 19, 2023
@mle-gall mle-gall force-pushed the feat/LIVE-9792/LLMParentAccountError branch from 91c2b9a to 572c1ef Compare December 20, 2023 09:08
KVNLS
KVNLS requested changes Dec 20, 2023
View reviewed changes
Copy link
Member

@KVNLS KVNLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we know that only Bitcoin and evm are impacted?

apps/ledger-live-mobile/src/components/SendRowsFee.tsx Outdated Show resolved Hide resolved
libs/coin-evm/src/getTransactionStatus.ts Show resolved Hide resolved
@mle-gall mle-gall force-pushed the feat/LIVE-9792/LLMParentAccountError branch from 572c1ef to 812f1cf Compare December 20, 2023 13:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

@github-actions github-actions bot added the Stale label Jan 5, 2024
@mle-gall mle-gall force-pushed the feat/LIVE-9792/LLMParentAccountError branch from 812f1cf to ac89e80 Compare January 5, 2024 15:49
@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jan 11, 2024
@mle-gall mle-gall force-pushed the feat/LIVE-9792/LLMParentAccountError branch from 89ab16d to c3a8908 Compare January 11, 2024 17:35
@mle-gall mle-gall force-pushed the feat/LIVE-9792/LLMParentAccountError branch from c3a8908 to 7aa85a0 Compare January 11, 2024 17:56
@mle-gall mle-gall requested a review from a team as a code owner January 11, 2024 17:56
@mle-gall mle-gall merged commit 1f8ba37 into develop Jan 12, 2024
56 of 57 checks passed
@mle-gall mle-gall deleted the feat/LIVE-9792/LLMParentAccountError branch January 12, 2024 16:01
@CremaFR CremaFR mentioned this pull request Sep 9, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrellard-ledger cgrellard-ledger cgrellard-ledger left review comments

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger left review comments

@KVNLS KVNLS KVNLS approved these changes

Assignees

@mle-gall mle-gall

Labels
desktop Has changes in LLD mobile Has changes in LLM Stale translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mle-gall @cgrellard-ledger @KVNLS @mcayuelas-ledger