Fix uncaught FirmwareNotRecognized in useAvailableLanguagesForDevice #5701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
live-github-bot
bot
added
desktop
ofreyssinet-ledger
changed the title
gre
approved these changes
Dec 8, 2023
ofreyssinet-ledger
force-pushed
the
bugfix/LIVE-10534-uncaught-firmwarenotrecognized
branch
from
f5d6109 to
21a2811
Compare
ofreyssinet-ledger
force-pushed
the
bugfix/LIVE-10534-uncaught-firmwarenotrecognized
branch
from
21a2811 to
612eefa
Compare
ofreyssinet-ledger
deleted the
bugfix/LIVE-10534-uncaught-firmwarenotrecognized
branch
aboissiere-ledger
pushed a commit
that referenced
this pull request
Dec 14, 2023
…5701) * fix(common/manager/hooks): catch error in useAvailableLanguagesForDevice * chore: changeset * fix(mobile/sentry): add FirmwareNotRecognized to ignored errors * chore: changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
An error appeared on Sentry for the latest LLD pre-release builds (2.73.0-next.0 and 2.73.0-next.1).
Basically it’s an uncaught exception in a promise in the hook
useAvailableLanguagesForDevicethat is used notably in the “language settings” section.It will be triggered every time a user with a wrong value for “My Ledger provider” (a provider for which the device firmware is unknown, for instance provider 1 with a
x.y.z-rcAfirmware etc.) navigates to the settings.It was not visible on Sentry previously because the error was a simple
“LedgerAPI4xx”and in my remapping of the error to something more specific (“FirmwareNotRecognized”), I didn’t add it to the list of ignored errors for Sentry.❓ Context
✅ Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.
npx changesetwas attached.🧐 Checklist for the PR Reviewers