Bugfix/live 5056 error mapping not found entity #5315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6da823c The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
live-github-bot
bot
added
desktop
alexandremgo
reviewed
Nov 7, 2023
| @@ -457,9 +465,9 @@ const getDeviceVersion: (targetId: string | number, provider: number) => Promise | |||
| target_id: targetId, | |||
| }, | |||
| }).catch(error => { | |||
| const status = error && (error.status || (error.response && error.response.status)); // FIXME LLD is doing error remapping already. we probably need to move the remapping in live-common | |||
| const status = error?.status || error?.response?.status; | |||
ofreyssinet-ledger
force-pushed
the
bugfix/LIVE-5056-error-mapping-not-found-entity
branch
from
7091bfd to
6da823c
Compare
ofreyssinet-ledger
deleted the
bugfix/LIVE-5056-error-mapping-not-found-entity
branch
sshmaxime
pushed a commit
that referenced
this pull request
Nov 9, 2023
* fix(common, llm, lld): better wording of not found entity error * chore: changeset * fix(common/manager api): remap 404 error in get_firmware_version * fix(lld, llm): wording capitalisation * fix(llm/pairing/RenderError): properly render wrong provider error * refactor(common/manager/api): clearer code + remove 4 year old FIXME * fix(common/manager/api): remove bad practice of checking error message
lvndry
pushed a commit
that referenced
this pull request
Nov 14, 2023
* fix(common, llm, lld): better wording of not found entity error * chore: changeset * fix(common/manager api): remap 404 error in get_firmware_version * fix(lld, llm): wording capitalisation * fix(llm/pairing/RenderError): properly render wrong provider error * refactor(common/manager/api): clearer code + remove 4 year old FIXME * fix(common/manager/api): remove bad practice of checking error message
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Improve the error mapping for the 404 response from some endpoints of the manager API, which is due to the provider number being wrong for the requested firmware version.
Currently the message shown is either:
Device firmware is not recognized, please contact Ledger supporton LLD if the error comes from the/get_device_versionAPI call.not found entity.The new improved message is:
Invalid ProviderYou have to change "My Ledger provider" setting. To change it, open Ledger Live "Settings", select "Experimental features", and then select a different provider.❓ Context
commonlldllm✅ Checklist
📸 Demo
LLD
Screen.Recording.2023-11-03.at.17.25.56.mov
LLM
Simulator.Screen.Recording.-.iPhone.14.-.2023-11-03.at.17.06.38.mp4
LLM old device pairing flow
RPReplay_Final1699269969.MP4
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.