Replace webpack with vite.js #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 5afac23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
common
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
Codecov Report
@@ Coverage Diff @@
## develop #364 +/- ##
===========================================
- Coverage 47.94% 47.60% -0.34%
===========================================
Files 602 598 -4
Lines 26550 26419 -131
Branches 6792 6760 -32
===========================================
- Hits 12730 12578 -152
- Misses 13768 13790 +22
+ Partials 52 51 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Justkant
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR aims to replace
webpackwith vite.js to improve the developer experience while working on ledger live desktop.Benefits: fast cold boot time, instant hot reload ✨ .
Unfortunately, vite.js is quite rigid, and the following impactful changes have been made to make it work properly:
.jsto.jsxfiles when needed (jsx inside).@ledgerhq/live-commonto esm in addition to commonjs and added subpath exports.@ledgerhq/hw-app-btcto esm in addition to commonjs and added subpath exports.@ledgerhq/devices./libprefixed paths to@ledgerhq/live-commonand@ledgerhq/hw-app-btc.🔥 There are breaking changes for
@ledgerhq/live-common,@ledgerhq/devicesand@ledgerhq/hw-app-btcconsumersReason
To fully embrace the "bundleless"
vite.jsapproach, it is necessary to transpile our packages contained in the monorepository to the ESM format.At the same time we cannot afford to break commonjs support for node.js code requiring the same packages, so we must also transpile to commonjs.
The hard part is that we have shared code (renderer/main processes) in LLD and depending on which entry point we must be able to dispatch to the right format.
Until now we added the
/libprefix to directly point to transpiled files when importing the library (ex:import whatever from "@ledgerhq/live-common/lib/whatever"). This is not possible anymore since we have both/liband/lib-esdirectories.The changes
The "official" workaround is to add subpath exports to silently map subpaths to
/lib/*and/lib-es.The configuration in the
package.jsonfile is something like:Which makes the following import…
import { createDataModel } from "@ledgerhq/live-common/DataModel";…mapped to…
import { createDataModel } from "@ledgerhq/live-common/lib-es/DataModel";…and the following require…
const { createDataModel } = require("@ledgerhq/live-common/DataModel");…is mapped to:
const { createDataModel } = require("@ledgerhq/live-common/lib/DataModel");The limitations
As highlighted here (nodejs/node#39994), it is not possible to target folders directly when using subpath exports.
The workaround is to suffix the call with
/index(or/).For instance,
import * as currencies from "@ledgerhq/live-common/currencies";must be rewritten toimport * as currencies from "@ledgerhq/live-common/currencies/index";This PR takes care of renaming every imports properly but will break for external projects importing subpaths with
/liband targeting a folder.❓ Context
✅ Checklist
@ledgerhq/live-common@ledgerhq/hw-app-btc@ledgerhq/devices📸 Demo
Full boot + hot reload ⚡
screen-recording-2022-06-17-at-124531_8i2MaEI4.mp4
Just hot reload
Screen.Recording.2022-06-14.at.15.10.36.mov
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.