-
Notifications
You must be signed in to change notification settings - Fork 326
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #364 from LedgerHQ/support/vitejs
Replace webpack with vite.js
- Loading branch information
Showing
2,141 changed files
with
66,031 additions
and
66,678 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
--- | ||
"@ledgerhq/live-common": major | ||
"@ledgerhq/devices": major | ||
"@ledgerhq/hw-app-btc": major | ||
"@ledgerhq/live-cli": patch | ||
"ledger-live-desktop": patch | ||
"live-mobile": patch | ||
"@ledgerhq/hw-app-eth": patch | ||
"@ledgerhq/hw-transport-node-ble": patch | ||
"@ledgerhq/hw-transport-node-hid-noevents": patch | ||
"@ledgerhq/hw-transport-web-ble": patch | ||
"@ledgerhq/hw-transport-webhid": patch | ||
"@ledgerhq/hw-transport-webusb": patch | ||
"@ledgerhq/react-native-hw-transport-ble": patch | ||
"@ledgerhq/icons-ui": patch | ||
"@ledgerhq/react-ui": patch | ||
"has-hash-commit-deps": patch | ||
"@actions/submit-bot-report": patch | ||
"@actions/upload-images": patch | ||
"esbuild-utils": patch | ||
"live-github-bot": patch | ||
"native-modules-tools": patch | ||
--- | ||
|
||
#### Replace [webpack](https://webpack.js.org/) with [vite.js](https://vitejs.dev/) to speed up the ledger live desktop development process. | ||
|
||
To fully embrace the "bundleless" vite.js approach, it is necessary to transpile our packages contained in the monorepository to the ESM format, and [subpath exports](https://nodejs.org/api/packages.html#subpath-exports) have been added to silently map to commonjs or esm depending on the need. | ||
|
||
#### 🔥 BREAKING CHANGES for `@ledgerhq/live-common`, `@ledgerhq/devices` and `@ledgerhq/hw-app-btc` consumers. | ||
|
||
As highlighted [here](https://github.com/nodejs/node#39994), it is not possible to target folders directly when using subpath exports. | ||
|
||
The workaround is to suffix the call with `/index` (or `/`). | ||
|
||
For instance… | ||
|
||
```ts | ||
import * as currencies from "@ledgerhq/live-common/currencies"; | ||
``` | ||
|
||
…must be rewritten to… | ||
|
||
```ts | ||
import * as currencies from "@ledgerhq/live-common/currencies/index;"; | ||
``` | ||
|
||
…or: | ||
|
||
```ts | ||
import * as currencies from "@ledgerhq/live-common/currencies/;"; | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
cf80564
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ 2 txs ($13.91) for [Bot 'Ethereum'](https://github.com/LedgerHQ/ledger-live-common/actions/runs/2617399946)
Details of the 2 mutations
Spec BSC (6)
Spec Polygon (failed)
Spec Ethereum (failed)
Spec Ethereum Classic (6)
Spec Ethereum Ropsten (failed)
Details of the 11 uncovered mutations
Spec BSC (2)
Spec Polygon (2)
Spec Ethereum (6)
Spec Ethereum Ropsten (1)
Portfolio ($13.91)
Details of the 5 currencies