ci: add CI job to check whether anvil state is up to date #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricomateo
force-pushed
the
workflow-to-check-anvil-state
branch
from
5ac67a9 to
895012a
Compare
ricomateo
changed the title
pablodeymo
approved these changes
Jan 20, 2025
MegaRedHand
pushed a commit
that referenced
this pull request
Feb 4, 2025
Fixes #234 This PR introduces the following changes * Adds a CI job to check if the anvil dump state is up to date. * Fixes the anvil's initial timestamp, otherwise the dump state will be different each time (since the timestamps are included in the state). * Updates the anvil dump state. The CI job works by generating a new anvil state and comparing it against the existing one using the `diff` command. If the new anvil state is different it means the existing one is outdated and therefore the CI will fail. **Note:** before performing the comparison between the existing and the new state, both files are sorted since the JSON format does preserve item order. - [ ] New features are tested and documented - [ ] PR has one of the `changelog-X` labels (if applies) - [ ] Code deprecates any old functionality before removing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #234
What Changed?
This PR introduces the following changes
The CI job works by generating a new anvil state and comparing it against the existing one using the
diffcommand.If the new anvil state is different it means the existing one is outdated and therefore the CI will fail.
Note: before performing the comparison between the existing and the new state, both files are sorted since the JSON format does preserve item order.
Reviewer Checklist
changelog-Xlabels (if applies)