Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workflow to check the anvil state dump is up to date #234

Closed
MegaRedHand opened this issue Jan 17, 2025 · 0 comments · Fixed by #237
Closed

Add workflow to check the anvil state dump is up to date #234

MegaRedHand opened this issue Jan 17, 2025 · 0 comments · Fixed by #237
Assignees
@ricomateo

Comments

@MegaRedHand
Copy link
Contributor

No description provided.

@ricomateo ricomateo self-assigned this Jan 20, 2025
@ricomateo ricomateo mentioned this issue Jan 20, 2025
Merged
3 tasks
pablodeymo pushed a commit that referenced this issue Jan 20, 2025
@ricomateo
ci: add CI job to check whether anvil state is up to date (#237)
d4ef497 
Fixes #234 

### What Changed?
This PR introduces the following changes
* Adds a CI job to check if the anvil dump state is up to date.
* Fixes the anvil's initial timestamp, otherwise the dump state will be
different each time (since the timestamps are included in the state).
* Updates the anvil dump state.

The CI job works by generating a new anvil state and comparing it
against the existing one using the `diff` command.
If the new anvil state is different it means the existing one is
outdated and therefore the CI will fail.
**Note:** before performing the comparison between the existing and the
new state, both files are sorted since the JSON format does preserve
item order.

### Reviewer Checklist

- [ ] New features are tested and documented
- [ ] PR has one of the `changelog-X` labels (if applies)
- [ ] Code deprecates any old functionality before removing it
MegaRedHand pushed a commit that referenced this issue Feb 4, 2025
@ricomateo @MegaRedHand
ci: add CI job to check whether anvil state is up to date (#237)
2b980f3 
Fixes #234

This PR introduces the following changes
* Adds a CI job to check if the anvil dump state is up to date.
* Fixes the anvil's initial timestamp, otherwise the dump state will be
different each time (since the timestamps are included in the state).
* Updates the anvil dump state.

The CI job works by generating a new anvil state and comparing it
against the existing one using the `diff` command.
If the new anvil state is different it means the existing one is
outdated and therefore the CI will fail.
**Note:** before performing the comparison between the existing and the
new state, both files are sorted since the JSON format does preserve
item order.

- [ ] New features are tested and documented
- [ ] PR has one of the `changelog-X` labels (if applies)
- [ ] Code deprecates any old functionality before removing it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricomateo ricomateo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: add CI job to check whether anvil state is up to date Layr-Labs/eigensdk-rs
2 participants
@MegaRedHand @ricomateo