[pl]: Missing keys + stylistical fixes, better comprehension #4761
Conversation
fork sync
fork sync
fork sync
fork sync
|
@makowskid can you check the tests? All test cases failed now because of [pl] locale. |
|
sh**, but why? I have only changed translation strings, checking |
andrey-helldar
changed the title
| "not_regex": "Format pola jest nieprawidłowy.", | ||
| "numeric": "Pole musi być liczbą.", | ||
| "password.letters": "To pole musi zawierać przynajmniej jedną literę.", | ||
| "password.mixed": "To pole musi zawierać co najmniej jedną wielką i jedną małą literę.", | ||
| "password.numbers": "To pole musi zawierać co najmniej jedną cyfrę.", | ||
| "password.symbols": "To pole musi zawierać przynajmniej jeden symbol.", | ||
| "password.uncompromised": "Podane pole pojawiło się w wycieku danych. Proszę wybrać inną wartość pola.", | ||
| "password.uncompromised": "Pole :attribute pojawiło się w wycieku danych. Należy wybrać inną wartość.", |
There was a problem hiding this comment.
The inline translation must not contain a reference to the attribute name.
There was a problem hiding this comment.
found it, pushing the fix, sorry
There was a problem hiding this comment.
I can assume it should be like this here (wrote it by analogy with other fields):
| "password.uncompromised": "Pole :attribute pojawiło się w wycieku danych. Należy wybrać inną wartość.", | |
| "password.uncompromised": "To pole musi pojawiło się w wycieku danych. Należy wybrać inną wartość.", |
There was a problem hiding this comment.
pushed, hope all works now, sorry again, fat fingers
There was a problem hiding this comment.
@andrey-helldar I think now we have a different problem
https://github.com/Laravel-Lang/lang/actions/runs/8966720071/job/24622816598#step:5:35
1) Tests\PluginTest::testInline
The locales/pl/json-inline.json file must not contain the value: :attribute
Podane pole :attribute pojawiło się w wycieku danych. Wybierz inną wartość pola :attribute.
Failed asserting that true is false.
"The given :attribute has appeared in a data leak. Please choose a different :attribute.": "Podane pole :attribute pojawiło się w wycieku danych. Wybierz inną wartość pola :attribute."
This test assertion is obviously wrong.
There was a problem hiding this comment.
No, the test is correct. The inline translation file must not contain a reference to the attribute name.
There was a problem hiding this comment.
OK, you're right, this is the original EN version:
"The given :attribute has appeared in a data leak. Please choose a different :attribute.": "The given field has appeared in a data leak. Please choose a different field."
I was a bit confused about the :attribute key here, weird.
fix pushed, again
No description provided.