-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enabled verilator added test_tb_top, filelist files, common defines, … #81
Conversation
amnafayyaz28
commented
Jan 20, 2021
- Updated test_tb_top.cpp for the sim.vcd path according to the corresponding seed
- Added commands for verilator in rtl_simulation.yaml
- Added test_tb_top.cpp, file lists and common_define files for verilator
- Updated tracer.sv for the warnings in verilator
- Removed unnecessary comments from sim.py and c_sample test from the testlist.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look below & answer the questions before we can approve this.
integration_files/SweRV_EH1/snapshots/default/common_defines_verilator.vh
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amnafayyaz-lm what is google_riscv_dv doing here in the files changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amnafayyaz-lm Please fix the mentioned issues and then push to the same branch.
- removed empty c_sample test from testlist - added sim.vcd path in test_tb_top - added verilator tool commands in rtl_simulation.yaml - added common_defines.vh corresponding to the verilator in the snapshot folder - updated tracer.sv;Lint off. - added filelists corresponding to the verilator
59fa0a6
to
29840fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. Approved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved.
- removed empty c_sample test from testlist - added sim.vcd path in test_tb_top - added verilator tool commands in rtl_simulation.yaml - added common_defines.vh corresponding to the verilator in the snapshot folder - updated tracer.sv;Lint off. - added filelists corresponding to the verilator