Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled verilator added test_tb_top, filelist files, common defines, … #81

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

amnafayyaz28
Copy link
Contributor

  • Updated test_tb_top.cpp for the sim.vcd path according to the corresponding seed
  • Added commands for verilator in rtl_simulation.yaml
  • Added test_tb_top.cpp, file lists and common_define files for verilator
  • Updated tracer.sv for the warnings in verilator
  • Removed unnecessary comments from sim.py and c_sample test from the testlist.yaml

Copy link
Contributor

@mmhus mmhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look below & answer the questions before we can approve this.

@mmhus mmhus added the enhancement New feature or request label Jan 20, 2021
Copy link
Contributor

@haroon-shafique haroon-shafique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amnafayyaz-lm what is google_riscv_dv doing here in the files changed?

Copy link
Contributor

@haroon-shafique haroon-shafique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amnafayyaz-lm Please fix the mentioned issues and then push to the same branch.

integration_files/SweRV_EH1/yaml/rtl_simulation.yaml Outdated Show resolved Hide resolved
- removed empty c_sample test from testlist
- added sim.vcd path in test_tb_top
- added verilator tool commands in rtl_simulation.yaml
- added common_defines.vh corresponding to the verilator in the snapshot
folder
- updated tracer.sv;Lint off.
- added filelists corresponding to the verilator
Copy link
Contributor

@haroon-shafique haroon-shafique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Approved!

Copy link
Contributor

@mmhus mmhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

@mmhus mmhus merged commit 05cc33a into master Jan 22, 2021
@mmhus mmhus deleted the verilator_enabled branch January 22, 2021 07:07
farooqahmed-lm pushed a commit that referenced this pull request Mar 19, 2021
- removed empty c_sample test from testlist
- added sim.vcd path in test_tb_top
- added verilator tool commands in rtl_simulation.yaml
- added common_defines.vh corresponding to the verilator in the snapshot
folder
- updated tracer.sv;Lint off.
- added filelists corresponding to the verilator
@amnafayyaz28 amnafayyaz28 linked an issue Apr 19, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Verilator in the RTL Simulation Flow for SweRV integration
3 participants