Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix(home): redirect to home after deleting wallet #1015

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

mrfelton
Copy link
Member

@mrfelton mrfelton commented Dec 4, 2018

Description:

Ensure that the user is redirected to the homepage after deleting a wallet. Unset the activeWallet and ensure that the no wallet selected message is visible.

Motivation and Context:

Fix #1012

How Has This Been Tested?

Manually

Screenshots (if appropriate):

image

Types of changes:

Bug Fix

Checklist:

  • My code follows the code style of this project.
  • I have reviewed and updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes where needed.
  • All new and existing tests passed.
  • My commits have been squashed into a concise set of changes.

@mrfelton mrfelton added type: bug 🐛 Something isn't working branch: next labels Dec 4, 2018
@mrfelton mrfelton self-assigned this Dec 4, 2018
@mrfelton mrfelton requested a review from JimmyMow December 4, 2018 09:50
@mrfelton mrfelton added this to the v0.3.0-beta milestone Dec 4, 2018
@lieteau2
Copy link

lieteau2 commented Dec 4, 2018

Test ACK e368df6

@JimmyMow JimmyMow added the status: needs rebase Issue needs to be rebased on top of the main branch label Dec 4, 2018
@JimmyMow
Copy link
Member

JimmyMow commented Dec 4, 2018

@mrfelton can you rebase?

Ensure that the user is redirected to the homepage after deleting a
wallet. Unset the `activeWallet` and ensure that the `no wallet
selected` message is visible.

Fix LN-Zap#1012
@mrfelton mrfelton force-pushed the fix/delete-wallet-redirect branch from e368df6 to 01ff0e8 Compare December 4, 2018 20:38
@mrfelton
Copy link
Member Author

mrfelton commented Dec 4, 2018

rebased @JimmyMow

@mrfelton mrfelton removed the status: needs rebase Issue needs to be rebased on top of the main branch label Dec 4, 2018
Copy link
Member

@JimmyMow JimmyMow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK 01ff0e8

@JimmyMow JimmyMow merged commit f90361f into LN-Zap:next Dec 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
branch: next type: bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants