Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Deleting a wallet leads me to blank screen (Next) #1012

Closed
JimmyMow opened this issue Dec 4, 2018 · 2 comments
Closed

Deleting a wallet leads me to blank screen (Next) #1012

JimmyMow opened this issue Dec 4, 2018 · 2 comments
Assignees
@mrfelton
Labels
branch: next type: bug 🐛 Something isn't working
Milestone
v0.3.0-beta

Comments

@JimmyMow
Copy link
Member

JimmyMow commented Dec 4, 2018

I deleted one of my non-used testnet wallets and was sent to a blank screen.

See screencast here: https://streamable.com/d27ew

Expected Behavior

I think Zap should go to some other wallet, even if it is random, I think that would be fine.
@mrfelton mrfelton added this to the v0.3.0 milestone Dec 4, 2018
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Dec 4, 2018
@mrfelton
fix(home): redirect to home after deleting wallet
e368df6 
Ensure that the user is redirected to the homepage after deleting a
wallet. Unset the `activeWallet` and ensure that the `no wallet
selected` message is visible.

Fix LN-Zap#1012
@mrfelton mrfelton mentioned this issue Dec 4, 2018
Merged
6 tasks
@mrfelton
Copy link
Member

mrfelton commented Dec 4, 2018

@JimmyMow we already had a screen to handle the case where no wallet is selected, so I have updated to code to ensure that is used. See #1015

I did originally have it set up to select the first wallet in the list on delete (if there was one) but I think the UX was bad - it's confusing to be taken directly to an unrelated wallet after deleting one of your wallets and it's not clear to the user exactly what happened. By showing the user the NoWallets component instead it's very clear that the wallet was deleted and that they should now either select one from their list or create a new one.

@mrfelton mrfelton added the type: bug 🐛 Something isn't working label Dec 4, 2018
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Dec 4, 2018
@mrfelton
fix(home): redirect to home after deleting wallet
01ff0e8 
Ensure that the user is redirected to the homepage after deleting a
wallet. Unset the `activeWallet` and ensure that the `no wallet
selected` message is visible.

Fix LN-Zap#1012
@mrfelton
Copy link
Member

mrfelton commented Dec 5, 2018

Fixed via #1015

@mrfelton mrfelton closed this as completed Dec 5, 2018
mrfelton added a commit that referenced this issue Dec 12, 2018
@mrfelton
fix(home): redirect to home after deleting wallet
ad30bb7 
Ensure that the user is redirected to the homepage after deleting a
wallet. Unset the `activeWallet` and ensure that the `no wallet
selected` message is visible.

Fix #1012
mrfelton added a commit that referenced this issue Dec 12, 2018
@mrfelton
fix(home): redirect to home after deleting wallet
79945f2 
Ensure that the user is redirected to the homepage after deleting a
wallet. Unset the `activeWallet` and ensure that the `no wallet
selected` message is visible.

Fix #1012
mrfelton added a commit that referenced this issue Dec 15, 2018
@mrfelton
fix(home): redirect to home after deleting wallet
4190fd1 
Ensure that the user is redirected to the homepage after deleting a
wallet. Unset the `activeWallet` and ensure that the `no wallet
selected` message is visible.

Fix #1012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mrfelton mrfelton

Labels
branch: next type: bug 🐛 Something isn't working
Projects
None yet
Milestone
v0.3.0-beta
Development

No branches or pull requests
2 participants
@mrfelton @JimmyMow