Added automatic dark note on light background for midi clips.

[aakers24]

Closes #6526

[Veratil]

Thanks! Can you share a screenshot of it working for various colors both light and dark?

[aakers24]

[Veratil]

I feel the muted clips contrast on grey isn't as good as it could be. Not sure it's a problem, but what would happen if we tried to make those notes get slightly lighter? It would have an effect on the rest, but curious how much.

[aakers24]

How does this look? I feel like it's more visible, but less obvious that they're muted. Maybe this is a happy medium? I played around with it and much more than this makes it hard for me to tell which are muted or not.

[allejok96]

This is great. Personally I don't see an issue with the contrast, but if we change it, it should be done inside style.css and not hardcoded.

IMHO (not necessarily related to this PR) muted clips should always turn grey, no matter what color they have. Also when selecting clips they should always turn blue. Currently custom colored clips are just darkened when selected or muted... see ClipView::getColorForDisplay

[zonkmachine]

I stressed through the review yesterday and had a second look.

The demo track Greippi - Krem Kaakkuja has colored tracks so it lends itself to comparing before/after this fix.
Here are eight screenshots side by side. As you can see from the bottom row, the unmuted notes also changes by this approach. I'd prefer the old old unmuted look and the new muted. Can we have both?

Top row ------- default theme - unmuted/muted, classic theme - unmuted/muted
Bottom row -- default theme - unmuted/muted, classic theme - unmuted/muted

[zonkmachine]

See comment #6539 (comment)

In b224f4d the colors of the unmuted tracks are now darker/less visible.

[zonkmachine]

Looks good to go! Caveat, I haven't tried it in any other themes than the ones we ship but this looks like a nice change to me.

[DomClark]

The code looks fine, and works with the default themes. A more thorough implementation could use the luminance of the colour rather than the HSL lightness, and compare it to the luminance of the note colour rather than a fixed constant.