Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes is barely visible if the Track color is light-colored #6526

Closed
SatyrDiamond opened this issue Oct 3, 2022 · 4 comments · Fixed by #6539
Closed

Notes is barely visible if the Track color is light-colored #6526

SatyrDiamond opened this issue Oct 3, 2022 · 4 comments · Fixed by #6539

Comments

@SatyrDiamond
Copy link

SatyrDiamond commented Oct 3, 2022

maybe make the notes black or dark-gray if the track color is light-colored
2022-09-01_04-06

@SatyrDiamond SatyrDiamond changed the title Notes is barely visible if the Track color is white Notes is barely visible if the Track color is bright Oct 3, 2022
@SatyrDiamond SatyrDiamond changed the title Notes is barely visible if the Track color is bright Notes is barely visible if the Track color is light-colored Oct 3, 2022
@PhysSong PhysSong added the gui label Oct 3, 2022
@musikBear
Copy link

I remember this from an other ticket, but find it ..i cant.
Since it is user that has chosen to have very bright clip-colors, this could be solved with a user-toggle for clip-names. There are no reason for a RGB based logic for the name -imo

@zonkmachine
Copy link
Member

Maybe allow changing color for the notes. You could also have an 'xor' function to change the note color if they are too close to that of the track.

@allejok96
Copy link
Contributor

+1 for automatic dark on light background.

For anyone interested in fixing this, here is the line that decides color for notes:

QColor noteFillColor = muted ? getMutedNoteFillColor() : getNoteFillColor();


And - this is not really relevant for this issue - this line in the header file creates a setter and getter function that is called by Qt when the theme is loaded. So setNoteFillColor() is called with the value specified in style.css.

@danik292
Copy link

@SatyrDiamond Its default or classics theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants