Extract TemplatesMenu class from MainWindow

[winniehell]

Extracts the logic for the project template menu from MainWindow into a new class.

This does not change or add functionality. It's mainly intended to reduce the size of MainWindow and allow extracting the toolbar logic in the long term.

[winniehell]

@lukas-w Can I ask you to take a look at this?

[winniehell]

@lukas-w Thank you for the review! I have addressed your comments. Can you please take another look?

[lukas-w]

Thanks. Please avoid force-pushing to make the review process easier. We can squash commits later when merging.

[lukas-w]

There's inconsistent indentation in TemplatesMenu.h and TemplatesMenu.cpp. Please check that you use one tab for indentation everywhere.

[winniehell]

Please avoid force-pushing to make the review process easier.

Sorry, I will try to remember in the future.

Just out of curiosity—can you explain how it makes reviews harder?

There's inconsistent indentation

Thank you for catching this! 👍 It should be fixed now. I must say I can't wait for #4690.

@lukas-w Can I ask you for yet another look please? 😃

[lukas-w]

Just out of curiosity—can you explain how it makes reviews harder?

If you don't force push but add new changes as additional commits, I can easily see what changes you made since I last viewed the PR.

[winniehell]

I can easily see what changes you made since I last viewed the PR.

@lukas-w Are you aware that even with force push, you can click the force-pushed link to get a diff since the last push?

Also I see you approve already but the needs testing label is still there. Anything I can do to help testing?

[winniehell]

@lukas-w Please let me know if I can do anything to get this finished 😃

[lukas-w]

Just need to find time for testing (unless someone beats me to it).

[lukas-w]

Made one more minor change via ebf6b92, merging. Thanks @winniehell 👍

[winniehell]

Thank you @lukas-w! 🙇‍♂️