WIP: Redesign time display #5118
Conversation
| m_milliSecondsLabel.setAlignment(Qt::AlignRight); | ||
| m_milliSecondsLabel.setStyleSheet(labelStyle); | ||
| m_milliSecondsValue.setAlignment(Qt::AlignRight); | ||
| m_milliSecondsValue.setStyleSheet(valueStyle); |
There was a problem hiding this comment.
This repetition deserves its own widget.
| m_spinBoxesLayout.addWidget( &m_milliSecondsLabel, 0, 2 ); | ||
| m_spinBoxesLayout.addWidget( &m_milliSecondsValue, 1, 2 ); | ||
|
|
||
| this->setStyleSheet( "TimeDisplayWidget { border-radius: 4px; background-color: rgba(0,0,0,70); margin: 8px; padding: 4px; }" ); |
There was a problem hiding this comment.
This should go in the stylesheet.
| this->setStyleSheet( "TimeDisplayWidget { border-radius: 4px; background-color: rgba(0,0,0,70); margin: 8px; padding: 4px; }" ); | ||
|
|
||
| QString labelStyle = "font-size: 10px;"; | ||
| QString valueStyle = "color: #0bd556; font-size: 24px;"; |
There was a problem hiding this comment.
This should go in the stylesheet.
winniehell
force-pushed
the
winniehell-time-display
branch
3 times, most recently
from
8c66de4
to
f239080
Compare
winniehell
force-pushed
the
winniehell-time-display
branch
from
f239080
to
6857333
Compare
|
In my opinion numbers should have same style, now your PR looks quite incoherently. |
|
@qnebra Yes, I agree! 👍 I will create another pull request to TEMPO/BPM and TIME SIG consistent after this design got approved. |
|
@Umcaruje given that you are the UI/UX maintainer, can I get your feedback here? |
|
In my opinion, the number size is a bit too large, especially if you compare it to the buttons on the left, so I would make it a bit smaller, something around 20px should be good
I would suggest you do this in this PR. Also, I really liked the idea of either making the unused zeroes in the minutes darker, that you posted somewhere else. Also I would return the CPU and waveform meter to its previous place. All in all, this looks more modern and I'm all for it, but the tempo and time signature should be integrated into the actual design, as this looks wildly inconsistent at the moment |
|
@Umcaruje Thank you for your feedback! 👍
sure, I will give that a try.
My intention was to keep this one as small as possible code-wise. However I trust your judgement and will update the other two components as well.
Would you restrict that to minutes (and bars) only or should I apply that to all segments?
Thank you for catching this! ❤️ This was definitely not intended but I didn't notice. 🙈 I will revert that change. |
Yeah but in terms of design it will be much easier to fine tune it if it's in the same PR.
Only minutes and bars, it wouldn't make sense on the other values. |
|
It seems like there's another work #5261 in progress. |
|
yep, thank you @PhysSong. I'm closing this one. |
This creates a new design for the time display widget.
It is still work in progress because the code needs some cleanup before merging.
video:
new-time-display.zip
closes #5097