Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable tab widget #4906

Merged
merged 7 commits into from
Apr 22, 2019
Merged

Commits on Mar 16, 2019

  1. Configuration menu
    Copy the full SHA
    9aa997e View commit details
    Browse the repository at this point in the history
  2. Allow instrument views to grow with contents

    Make InstrumentTrackWindow as large as the InstrumentView requires
    JohannesLorenz committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    dd43127 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2019

  1. Fix too small instrument tabs

    Previously, they had been resized by the fixed size parent tab widget. We need
    to do this manually now.
    JohannesLorenz committed Mar 17, 2019
    Configuration menu
    Copy the full SHA
    7e7141f View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2019

  1. Fix instrument window tab sizes

    - Fix the instrument window tabs minimum width and height formulae
    - Also set minimum height and width for instrument tab
    JohannesLorenz committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    d52c220 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2019

  1. Fix -1 offset in plugin tab

    In the instrument plugin tab, there was an orange stripe for
    TripleOscillator. This was because internally, TabWidget moves up the
    widget by 1 (TabWidget.cpp, line 89).
    
    The size of the whole window is:
    
    ```
    widget->height() + m_tabbarHeight - 1
    ```
    
    So this code adds an offset of "-1" to the necessary computations.
    JohannesLorenz committed Apr 20, 2019
    Configuration menu
    Copy the full SHA
    91099e2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    53942a1 View commit details
    Browse the repository at this point in the history
  3. Coding conventions

    JohannesLorenz committed Apr 20, 2019
    Configuration menu
    Copy the full SHA
    e1df16c View commit details
    Browse the repository at this point in the history